-
Notifications
You must be signed in to change notification settings - Fork 16
feat(stdlib): Add fallback implementation of SHA256
black box function
#407
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once we resolve the nits around styling etc, I think we can merge this in under a experimental feature flag, until we get someone to comb through the logic of sha256, so the PR does not get stale.
We would only need it to be on the method that converts sha256 blackbox functions into regular gates, so tests won't be affected since they will be switched on in acvm/stdlib unconditionally.
@Ethan-000 Please ping me when you want a re-review! |
I think its ready for a re-review :). I did all the suggested changes other than "using mutable reference for |
also added a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is okay to merge since its isolated and not enabled -- great work!
Description
Problem*
Resolves
Summary*
Additional Context
PR Checklist*
cargo fmt
on default settings.