Skip to content
This repository has been archived by the owner on Apr 9, 2024. It is now read-only.

feat(acvm)!: Remove OpcodeResolution enum #400

Merged
merged 8 commits into from
Jul 26, 2023

Conversation

TomAFrench
Copy link
Member

Description

Problem*

Summary*

The assumption made in #399 that each opcode will be immediately executable means that we no longer need to track multiple different potential outcomes of an opcode - it either succeeds or fails. There's a slight special case with Brillig where it may require a foreign call but that's easy to handle.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@kevaundray kevaundray requested a review from guipublic June 26, 2023 10:49
@TomAFrench TomAFrench force-pushed the linear-acvm branch 2 times, most recently from 57ae6eb to 925e84e Compare July 5, 2023 10:14
@TomAFrench TomAFrench force-pushed the remove-opcode-resolution branch from b41eb13 to fb900c0 Compare July 12, 2023 08:19
@TomAFrench TomAFrench force-pushed the linear-acvm branch 3 times, most recently from 04599d4 to fb5a924 Compare July 17, 2023 10:41
@TomAFrench TomAFrench force-pushed the remove-opcode-resolution branch from fb900c0 to a3725ca Compare July 17, 2023 13:26
@TomAFrench TomAFrench force-pushed the remove-opcode-resolution branch from 2110f06 to 57ad06e Compare July 24, 2023 06:07
Base automatically changed from linear-acvm to master July 26, 2023 08:56
@TomAFrench TomAFrench marked this pull request as ready for review July 26, 2023 09:01
@TomAFrench TomAFrench requested a review from kevaundray July 26, 2023 09:45
@kevaundray kevaundray added this pull request to the merge queue Jul 26, 2023
Merged via the queue into master with commit d0ce48c Jul 26, 2023
@kevaundray kevaundray mentioned this pull request Jul 26, 2023
@TomAFrench TomAFrench deleted the remove-opcode-resolution branch July 26, 2023 11:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants