Skip to content
This repository has been archived by the owner on Apr 9, 2024. It is now read-only.

Add ability to specify message length as a witness for all hash functions #320

Closed
kevaundray opened this issue May 26, 2023 · 1 comment
Closed
Labels
enhancement New feature or request

Comments

@kevaundray
Copy link
Contributor

Problem

See Issue #313 for the Keccak variant.

This however makes Keccak seem special when infact this property can be applied to all hash functions, albeit they will be implemented differently internally since not all hash functions are sponge_absorb.

Happy Case

Add the ability to specify the message length as a witness for all hash functions

Alternatives Considered

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

No

Support Needs

No response

@kevaundray kevaundray added the enhancement New feature or request label May 26, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir May 26, 2023
@kevaundray kevaundray changed the title Add Variable Add ability to specify message length as a witness for all hash functions May 26, 2023
@TomAFrench
Copy link
Member

Closing as we're changing to implementing the internal sponge functions rather than a monolithic version which takes an arg.

@TomAFrench TomAFrench closed this as not planned Won't fix, can't repro, duplicate, stale Apr 9, 2024
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Apr 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
Archived in project
Development

No branches or pull requests

2 participants