Skip to content
This repository has been archived by the owner on Apr 9, 2024. It is now read-only.

Should we make BlackBox Functions heterogenous? #29

Closed
kevaundray opened this issue Dec 25, 2022 · 4 comments
Closed

Should we make BlackBox Functions heterogenous? #29

kevaundray opened this issue Dec 25, 2022 · 4 comments
Labels
question Further information is requested

Comments

@kevaundray
Copy link
Contributor

Currently all black box functions are defined to look the same via a FuncDefinition struct. It is however possible to have a similar structure to Directives and have each black box function define what unique types they require

@kevaundray kevaundray added the question Further information is requested label Dec 30, 2022
@kevaundray
Copy link
Contributor Author

One thing to consider is how the API will be used and which is more convenient and safe

@kevaundray
Copy link
Contributor Author

See here for more context into why this could be a goo advantage.

For AND gate, the num_bits parameter is technically not needed for both inputs

@guipublic
Copy link
Contributor

I answered those points in #53. Here the summary:
Non blackbox functions should be specific and have heterogeneous input
blackbox (i.e custom) functions should have homogenous input, but we should not require a num_bits for every witness.

@TomAFrench
Copy link
Member

Resolved in #269

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants