This repository has been archived by the owner on Apr 9, 2024. It is now read-only.
chore!: Remove manual serialization of Opcode
s in favour of serde
#286
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s)
(If it does not already exist, first create a GitHub issue that describes the problem this Pull Request (PR) solves before creating the PR and link it here.)
Resolves (link to issue)
Description
Discussed internally: We originally wanted an encoding which could be implemented in other languages easier. I thought that having a manual encoding and then specifying this in some documentation would have been the best way for this. Even if this was the case, we have had two serialization bugs and the effort for folks to modify this code has become unproductive.
There are still solutions to the problem of having other languages implement a deserialization strategy, they can choose to use rmp/json for example, which is available in most languages. For now, we use rmp by default with the read and write methods.
Summary of changes
(Describe the changes in this PR. Point out breaking changes if any.)
Dependency additions / changes
(If applicable.)
Test additions / changes
(If applicable.)
Checklist
cargo fmt
with default settings.Additional context
(If applicable.)