Skip to content
This repository has been archived by the owner on Apr 9, 2024. It is now read-only.

Should preprocess be two functions: generate_proving_key and generate_verification_key? #256

Closed
1 task done
phated opened this issue May 3, 2023 · 1 comment · Fixed by #514
Closed
1 task done
Labels
enhancement New feature or request

Comments

@phated
Copy link
Contributor

phated commented May 3, 2023

Problem

Currently, we require a preprocess function on the ProofSystem trait that needs to return the proving key and verification key; however the verifier might only need a verification key. Alternatively, backends such as https://github.com/TomAFrench/acvm-backend-groth16 generate the pk and vk at the same time.

Proposed solution

Figure out if we want to split these or if it would cause too much friction when implementing various backends.

Alternatives considered

Leave it as is.

Additional context

See thread at #231 (comment) for more discussion

Submission Checklist

  • Once I hit submit, I will assign this issue to the Project Board with the appropriate tags.
@phated phated added the enhancement New feature or request label May 3, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir May 3, 2023
@kevaundray
Copy link
Contributor

Generally they are generated at the same time in a one-off relative expensive operation. So I think its fine to have it as is.

@phated phated moved this from 📋 Backlog to 🏗 In progress in Noir May 8, 2023
@phated phated moved this from 🏗 In progress to 📋 Backlog in Noir May 8, 2023
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Aug 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants