Skip to content
This repository has been archived by the owner on Apr 9, 2024. It is now read-only.

feat(acvm)!: have all black box functions return Result<OpcodeResolution, OpcodeResolutionError> #237

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

TomAFrench
Copy link
Member

Related issue(s)

(If it does not already exist, first create a GitHub issue that describes the problem this Pull Request (PR) solves before creating the PR and link it here.)

Resolves (link to issue)

Description

Summary of changes

For consistency, all bb function implementations inside ACVM pass back a Result<OpcodeResolution, OpcodeResolutionError> so backends don't need to do anything other than forward the return value back into the ACVM.

Dependency additions / changes

(If applicable.)

Test additions / changes

(If applicable.)

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.

Additional context

(If applicable.)

@kevaundray kevaundray added this pull request to the merge queue Apr 26, 2023
Merged via the queue into master with commit e8e93fd Apr 26, 2023
@github-actions github-actions bot mentioned this pull request Apr 26, 2023
@TomAFrench TomAFrench deleted the more-blackbox-return-types branch April 26, 2023 22:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants