Skip to content
This repository has been archived by the owner on Apr 9, 2024. It is now read-only.

feat(acvm)!: implement hash_to_field_128_security #230

Merged
merged 2 commits into from
Apr 26, 2023

Conversation

TomAFrench
Copy link
Member

Related issue(s)

Resolves noir-lang/acvm-backend-barretenberg#138 (comment)

Description

Summary of changes

I've pulled down the implementation of BlackBoxFunc::HashToField128Security from aztec_backend.

The hash implementations in ACVM now use the checked versions of the reading/writing witness values and return a proper Result<OpcodeResolution, OpcodeResolutionError> response to be passed back into ACVM.

Dependency additions / changes

(If applicable.)

Test additions / changes

(If applicable.)

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.

Additional context

(If applicable.)

@TomAFrench TomAFrench requested a review from kevaundray April 25, 2023 20:01
@kevaundray kevaundray added this pull request to the merge queue Apr 26, 2023
Merged via the queue into master with commit 198fb69 Apr 26, 2023
@github-actions github-actions bot mentioned this pull request Apr 26, 2023
@TomAFrench TomAFrench deleted the generic_hash-refactor branch April 26, 2023 20:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants