This repository has been archived by the owner on Apr 9, 2024. It is now read-only.
feat(acvm)!: implement hash_to_field_128_security
#230
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s)
Resolves noir-lang/acvm-backend-barretenberg#138 (comment)
Description
Summary of changes
I've pulled down the implementation of
BlackBoxFunc::HashToField128Security
fromaztec_backend
.The hash implementations in ACVM now use the checked versions of the reading/writing witness values and return a proper
Result<OpcodeResolution, OpcodeResolutionError>
response to be passed back into ACVM.Dependency additions / changes
(If applicable.)
Test additions / changes
(If applicable.)
Checklist
cargo fmt
with default settings.Additional context
(If applicable.)