This repository has been archived by the owner on Apr 9, 2024. It is now read-only.
feat!: require Backend
to implement Default
trait
#223
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s)
(If it does not already exist, first create a GitHub issue that describes the problem this Pull Request (PR) solves before creating the PR and link it here.)
Resolves (link to issue)
Description
In our new merged
acvm-backend-barretenberg
crate, we're implementing theBackend
trait directly on theBarretenberg
struct rather than having a separatePlonk
unit struct which then constructsBarretenberg
when needed.https://github.com/noir-lang/aztec_backend/blob/9fed6e52778d993d7742c46bbeec66087958c075/acvm_backend_barretenberg/src/lib.rs#L21-L26
This means that when we're actually using the backend in Nargo we need to construct the struct, i.e we need to call
let backend = Barretenberg::default()
rather than just being able to dolet backend = Plonk
.Example: noir-lang/noir@ad822e6
We then want to enforce that this method exists on all backends so it must be included in the trait definition.
Summary of changes
(Describe the changes in this PR. Point out breaking changes if any.)
Dependency additions / changes
(If applicable.)
Test additions / changes
(If applicable.)
Checklist
cargo fmt
with default settings.Additional context
(If applicable.)