Skip to content
This repository has been archived by the owner on Apr 9, 2024. It is now read-only.

feat!: return PartialWitnessGeneratorStatus from PartialWitnessGenerator.solve #213

Merged
merged 1 commit into from
Apr 20, 2023

Conversation

TomAFrench
Copy link
Member

@TomAFrench TomAFrench commented Apr 20, 2023

Related issue(s)

Resolves #212

Description

Summary of changes

This PR makes the state of the PartialWitnessGenerator explicit in its return value rather than requiring callers to be aware of the internal logic by returning an enum describing the action which the caller must take.

Dependency additions / changes

(If applicable.)

Test additions / changes

(If applicable.)

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.

Additional context

(If applicable.)

@TomAFrench TomAFrench changed the title feat!: return PartialWitnessGeneratorStatus from `PartialWitnessGen… feat!: return PartialWitnessGeneratorStatus from PartialWitnessGenerator.solve Apr 20, 2023
@kevaundray kevaundray added this pull request to the merge queue Apr 20, 2023
Merged via the queue into master with commit e877bed Apr 20, 2023
@github-actions github-actions bot mentioned this pull request Apr 20, 2023
@TomAFrench TomAFrench deleted the solve-return-enum branch April 20, 2023 13:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Return an enum from PartialWitnessGenerator.solve to represent the action for the caller to take
2 participants