This repository has been archived by the owner on Apr 9, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s)
(If it does not already exist, first create a GitHub issue that describes the problem this Pull Request (PR) solves before creating the PR and link it here.)
Resolves (link to issue)
Description
Summary of changes
This PR migrates the remaining
Expression
arithmetic from noirc_evaluator. The aim behind this is so that we can remove some very verbose usage ofadd
andsubtract
The
add
function has been changed to be theadd_mul
method onExpression
soa + k * b
can be called asa.add_mul(k, b)
. I'm toying with the idea that this would be better named asmul_add
as we're first multiplying then adding so this may be clearer.add_mul
has had some refactoring applied to improve readability.The
+
and-
operator implementations have been updated to useadd_mul
under the hood as we should always havea + b == a.add_mul(1, b)
which may not be the case otherwise.I've also implemented
*
which replaces themul
function from noirc_evaluator.Dependency additions / changes
(If applicable.)
Test additions / changes
(If applicable.)
Checklist
cargo fmt
with default settings.Additional context
(If applicable.)