Skip to content
This repository has been archived by the owner on Apr 9, 2024. It is now read-only.

chore(acir)!: rename term_multiplication to push_multiplication_term #122

Merged
merged 2 commits into from
Feb 28, 2023

Conversation

TomAFrench
Copy link
Member

chore(acir)!: rename term_addition to push_addition_term

Related issue(s)

Resolves one item from #53

term_multiplication() and term_addition() are not clear and should be renamed into push_multiplication_term() and push_linear_term()

Description

Summary of changes

These two methods have been renamed to be clearer about what they do.

This is a relatively minor change but is breaking. We should delay merging until we are going to have a breaking release.

Dependency additions / changes

(If applicable.)

Test additions / changes

(If applicable.)

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.

Additional context

(If applicable.)

chore(acir)!: rename `term_addition` to `push_addition_term`
@TomAFrench TomAFrench added this pull request to the merge queue Feb 28, 2023
Merged via the queue into master with commit d389385 Feb 28, 2023
@github-actions github-actions bot mentioned this pull request Feb 28, 2023
@TomAFrench TomAFrench deleted the push-terms branch February 28, 2023 19:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants