You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
I'm in favour of removing the merkle tree implementation entirely. The compute_merkle_root function should live down in ACVM to match the other black box functions. Alternatively we remove this black box function entirely as we can implement it in a library while being more flexible
The merkle tree implementation is only used for calculating inputs for test cases so we can then remove it entirely.
Problem
The merkle.rs module in this crate uses a ton of unwraps. As soon as we land #151, we'll be able to avoid these.
Proposed solution
Either rewrite the module or remove it if we can. I'm not clear on where the merkle stuff should be happening (acvm vs backend).
Alternatives considered
No response
Additional context
No response
Submission Checklist
The text was updated successfully, but these errors were encountered: