This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
fix!: replace serialize_circuit function with from<&Circuit>
#118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomAFrench
approved these changes
Apr 17, 2023
TomAFrench
changed the title
from<&Circuit>serialize_circuit function with from<&Circuit>
TomAFrench
changed the title
serialize_circuit function with from<&Circuit>serialize_circuit function with from<&Circuit>
phated
changed the title
serialize_circuit function with from<&Circuit>serialize_circuit function with from<&Circuit>
TomAFrench
added a commit
that referenced
this pull request
Apr 17, 2023
* master: fix: replace `serialize_circuit` function with `from<&Circuit>` (#118)
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the
serialize_circuitfunction with afrom<&Circuit>implementation. This is the first step in hiding the ConstraintSystem from the public API. The next step will be to removepubfrom the fields on the struct and introduce a builder pattern for constructing ConstraintSystem in tests.