Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

express-graphql 0.5.4 doesn't work with react-relay-network-layer #19

Closed
genbit opened this issue Aug 26, 2016 · 3 comments
Closed

express-graphql 0.5.4 doesn't work with react-relay-network-layer #19

genbit opened this issue Aug 26, 2016 · 3 comments

Comments

@genbit
Copy link

genbit commented Aug 26, 2016

After upgrading to express-graphql 0.5.4, react-relay-network-layer cannot return data from original graphql queries, in another words - simply whole UI will be broken.

probably because they introduced small fix:

@chentsulin

Use end() to write final data (e01eb2e @chentsulin)

Will maybe look later into react-relay-network-layer code, but if owner can take a look it will be awesome

@nodkz
Copy link
Collaborator

nodkz commented Aug 29, 2016

Nice catch. Fixed in a couple of minutes.
Bumped 1.3.4.

Please check, how it works in your app.

@nodkz
Copy link
Collaborator

nodkz commented Aug 29, 2016

Step by step I'm rewriting own express implementation 😂

It will be cool if Lee accepted this PR: graphql/express-graphql#100

@genbit
Copy link
Author

genbit commented Aug 29, 2016

@nodkz looks like it's working, thanks for quick fix!

@genbit genbit closed this as completed Aug 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants