Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE 11 support / babel #371

Closed
dptoot opened this issue Sep 4, 2019 · 4 comments
Closed

IE 11 support / babel #371

dptoot opened this issue Sep 4, 2019 · 4 comments

Comments

@dptoot
Copy link

dptoot commented Sep 4, 2019

Node.js Version:

10

Operating System:

Windows

Steps to Produce Error:

Use opossum in IE 11.

It looks as though the opossum library isn't running through babel transpilation. This is causing our IE11 bundles to fail due to many non-supported ES6 features like template-literals and class syntax.

I would think the simple addition of adding a babel transpile, utilizing the babel-preset-env, to the build would suffice for enough support.

Thoughts?

@dptoot
Copy link
Author

dptoot commented Sep 4, 2019

I am able to workaround this today by adding a custom webpack rule to include opossum using our babel-loader. But I would say that this is usually up to the package to handle es5 support.

@tavogel
Copy link
Contributor

tavogel commented Oct 21, 2019

This fails for us when using UglifyJS as well. You can see template literals being used in the minified code:
https://cdn.jsdelivr.net/npm/[email protected]/dist/opossum.min.js

new Error(`Timed out after ${this.options.timeout}ms`)

@tavogel
Copy link
Contributor

tavogel commented Oct 21, 2019

I have opened a PR that works with babel-loader and core-js@3. Even if you don't want to use the core-js polyfills, you can use babel-loader and preset-env without useBuiltIns to at strip the template literals, and other syntactic sugar.

@lance
Copy link
Member

lance commented Oct 25, 2019

Fixed in #380

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants