Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add full support for webpack and angular #185

Merged
merged 7 commits into from
Apr 25, 2018

Conversation

lance
Copy link
Member

@lance lance commented Apr 22, 2018

Our webpack support needed some boosting to handle the use case presented by angular 5 and reported on here: #182

This pull request adds:

  • Browser and headless testing using webpack instead of browserify
  • Multiple webpack configurations: production, development and test
  • Maintains compatibility with circuitBreaker as a global variable in the browser (WE SHOULD DEPRECATE THIS)

Do not merge yet. I would like to add some documentation on this to the README.md, but I just haven't had the chance. I also think we can change the examples (or add new ones) that use webpack to bundle the app.

connected to: #182

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 100.0% when pulling d1e2228 on 182-fix-browser-for-angular into 0178e95 on master.

@coveralls
Copy link

coveralls commented Apr 22, 2018

Coverage Status

Coverage increased (+0.3%) to 100.0% when pulling 620ae79 on 182-fix-browser-for-angular into 0178e95 on master.

@lance lance changed the title feat: add full support for webpack and angular fix: add full support for webpack and angular Apr 23, 2018
@ghost ghost added the in progress label Apr 25, 2018
@ghost ghost removed the in progress label Apr 25, 2018
@ghost ghost added the in progress label Apr 25, 2018
@lance lance merged commit a8cdad6 into master Apr 25, 2018
@ghost ghost removed the in progress label Apr 25, 2018
@helio-frota helio-frota deleted the 182-fix-browser-for-angular branch July 28, 2020 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants