Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag the repository #820

Closed
nickandrew opened this issue Dec 6, 2015 · 2 comments
Closed

Tag the repository #820

nickandrew opened this issue Dec 6, 2015 · 2 comments

Comments

@nickandrew
Copy link
Contributor

Now that 1.4.0 is in master branch, I suggest a tag so git-describe will be useful.

I tagged https://github.com/nickandrew/nodemcu-firmware with 1.4.0-20151201 at the current master commit.

tag 1.4.0-20151201
Tagger: Nick Andrew <[email protected]>
Date:   Sun Dec 6 15:06:59 2015 +1100

NodeMCU 1.4.0 release 2015-12-01

This is the commit at which the work-in-progress 'dev' branch
replaced the 0.9.6 'master' branch.

Signed-off-by: Nick Andrew <[email protected]>

So now:

$ git describe
1.4.0-20151201-29-g5977633
This was referenced Dec 6, 2015
@marcelstoer
Copy link
Member

marcelstoer commented Jun 29, 2016

We started tagging the repository. However, since we did that on GitHub (so far) the tags are not annotated and this in turn means git describe still shows 0.9.6. Either we start tagging with git and then push the tags or you have to run git describe --tags (or --all).

@marcelstoer
Copy link
Member

marcelstoer commented Jun 29, 2016

While it is possible to convert a lightweight tag to an annotated tag it's a no-go once the tag has been released into the wild. So, I just made a mental note that we should use annotated tags from now on (git tag -a 1.5.1-master_20160731 -m "" and git push --tags).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants