-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing module documentation for crypto, rc, CoAP and DHT #486
Comments
TODO:@vowstar |
DHTLib is OK. |
I should be able to get some time on Monday to document the crypto module. Can/should I edit the wiki directly, or post text here for someone else to merge in? |
@jmattsson You could edit wiki directly, everyone can edit it ;) |
Okay, I'll do that then. I just didn't want to step on somebody's toes accidentaly. |
Crypto module docs added. Writing it made me think that the hex & base64 encoding should go in a different module or two, plus get the corresponding decode functions. E.g. hex.encode(str) + hex.decode(str) and base64.encode(str) + base64.decode(str). Thoughts? |
Don;t have CoAP doc. |
@jmattsson Johny, I am going to do a PR for the |
Yeah backwards compatibility is important, so I'd say leave the crypto entries in there for now. Once we're fully on top of documentation we can look at deprecating it officially. Maybe even add a c_printf() on use to that effect. Since you're looking at tackling this one, can I suggest another slightly different approach, where we have the modules |
I like that but I agree on the naming issue. Other libraries/languages sometimes call those things "endecoder". |
The main issue here, "missing documentation", is fixed in or tracked with #774. Closing this one. |
https://github.com/nodemcu/nodemcu-firmware/wiki/nodemcu_api_en-(dev096) is missing documentation for the 3 new modules crypto, rc, and DHT as well as CoAP.
The text was updated successfully, but these errors were encountered: