Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WebServer on top of httpserver for authentication handling of several routes #2968

Open
HHHartmann opened this issue Nov 22, 2019 · 6 comments
Assignees

Comments

@HHHartmann
Copy link
Member

HHHartmann commented Nov 22, 2019

Missing feature

There have been several calls for a WebServer lately.
Reference to our httpserver.lua or https://github.com/marcoskirsch/nodemcu-httpserver or #2957

Our httpserver.lua is sophisticated in using output buffering and having a flexible interface.
But it does not do anything out of the box, so I aim to have a WebServer which can be configured to serve static files with one line. Equally simple it can be configured to call dynamic APIs.

It will be easy to write and integrate individual filters, authentication, redirects or whatever middle-ware is needed.

Configuration will be similar to nodemcu-espress. I might also use their plugins and adapt them to our API.

Justification

Easy way to serve some pages.
@TerryE @marcelstoer @pjsg Do you think this is the right repo or should I put it in my own.
This would include several files for the core WebServer and some plugins.

Workarounds

Everybody write their own

@HHHartmann HHHartmann self-assigned this Nov 22, 2019
@marcelstoer
Copy link
Member

Amazing (or scary?) how many HTTP servers there exist for NodeMCU - I had no idea. This despite our FAQ stating

If you are trying to implement a user-interface or HTTP webserver in your ESP8266 then you are really abusing its intended purpose.

I don't have any preference as to where you are going with this code. Not having to maintain an HTTP module at all would also be fine i.e. we remove ours and link to yours instead.

@NiklausS
Copy link

@gregor,

.But it does not do anything out of the box, so I aim to have a WebServer which can be configured to serve static files with one line. Equally simple it can be configured to call dynamic APIs.

This was the idea when i wrote this.
https://github.com/NiklausS/nodemcu-firmware/blob/Webserver/docs/modules/httpd.md

I've also done some simple test with authentication. But as it is not secure, i didn't follow this further.

@stale
Copy link

stale bot commented Nov 19, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 19, 2020
@HHHartmann
Copy link
Member Author

I will eventually continue my work. Please have a bit more patience.

@stale stale bot removed the stale label Nov 20, 2020
@stale
Copy link

stale bot commented Apr 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 16, 2022
@HHHartmann
Copy link
Member Author

Need to make a pr for this

@stale stale bot removed the stale label Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants