Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shifting more pixels than available for ws2812.buffer:shift reboots #2946

Closed
HHHartmann opened this issue Oct 20, 2019 · 0 comments
Closed
Assignees
Labels

Comments

@HHHartmann
Copy link
Member

I found this error while writing tests for this module.
So the effort was worth it right away.
This Bug was introduced a while ago, so if we had had tests then it would not be there.

Expected behavior
buffer:shift with more pixels than selected(available) should throw an error.

Actual behavior
Reboots.

Test code

buffer = ws2812.newBuffer(4, 4)
buffer:shift(-10)

the last commad reboots the mcu

NodeMCU version
NodeMCU 3.0.0.0
branch: dev
commit: 0b90495

Hardware
standard dev board

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants