Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTD not building #2414

Closed
marcelstoer opened this issue Jun 29, 2018 · 4 comments
Closed

RTD not building #2414

marcelstoer opened this issue Jun 29, 2018 · 4 comments
Assignees

Comments

@marcelstoer
Copy link
Member

RTD silently updated their MkDocs version to 0.17.3. This breaks the docs build

WARNING - Config value: 'theme_dir'. Warning: The configuration option {0} has been deprecated and will be removed in a future release of MkDocs.

Aborted with 1 Configuration Warnings in 'strict' mode!

Currently our rtd-requirements.txt in the root is inactive. Analyze if we still need it.

@marcelstoer marcelstoer self-assigned this Jun 29, 2018
@marcelstoer marcelstoer added this to the next-release milestone Jun 30, 2018
@marcelstoer
Copy link
Member Author

All good now

@TerryE
Copy link
Collaborator

TerryE commented Jul 1, 2018

Thanks Marcel. I've just checked the dev documentation, and it looks good.

No doubt someone will pick up some typos but if you note there is now a whitepapers section and I've moved the two existing tutorial-style sections on the two file system variants as well as my LCD and LFS papers into this. I was in two minds about adding the LCD paper, but it is relevant because NodeMCU is different from standard and eLua implementations in that we get decent error reporting without paying a 100% RAM overhead.

Sorry for the digression, but the documentation system is seamless thanks to your work 👍

@marcelstoer
Copy link
Member Author

I noted the new section, thank you for that, makes sense to me. You had the LCD/LFS labels pointing to the respective other. I fixed that in 3f396cb.

For the record, the RTD issue: readthedocs/readthedocs.org#4314

@TerryE
Copy link
Collaborator

TerryE commented Jul 1, 2018

You had the LCD/LFS labels pointing to the respective other.

Durrrhh. Typical Terry mistake. Thanks for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants