-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The HTTP module has a bug that returns a binary with a byte of \0, which ends up with the actual data that's left behind #2405
Comments
兄弟,我也遇到了这个问题,我修掉了这个bug。你需要的话在群里找我(唯笑不哭)。 translation: |
@anod221 can you please describe the fix or even better create a pull request here? |
@marcelstoer I did these modification. The original source is hard to modify. So I didn't process some code which may cause the memory leak. |
@pjsg you were the last to work on the HTTP module, wonder what you make out of this. I'm certainly not in a position to process this. |
@marcelstoer, I had a quick scan of the code for the module In the meantime, those that need a workaround can do this in native Lua as per my HTTP_OTA.lua example. This also has the advantage that this algo is more stable for non-trivial files since it uses flow control to stop the sending server overrunning the ESP. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
We should at least mention this in documentation. I didn't get if the modifications by @anod221 introduced the memory leak but we should still check to move it here. |
Fixed with #2985 |
Expected behavior
Actual behavior
Test code
Provide a Minimal, Complete, and Verifiable example which will reproduce the problem.
BUG:
The HTTP module has a bug that returns a binary with a byte of \0, which ends up with the actual data that's left behind
data size must be is 101,but size now is 4
d2ZyAGFmZApzZGY=206 4 255 /9j/4A== 101
NodeMCU version
Which branch are you on? If you know the Git revision then add it here as well.
nodemcu-firmware 2.2
Hardware
Describe which ESP8266 device you use and document any special hardware setup
required to reproduce the problem.
The text was updated successfully, but these errors were encountered: