Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCRAM-SHA-1(-PLUS) + SCRAM-SHA-256(-PLUS) + SCRAM-SHA-512(-PLUS) + SCRAM-SHA3-512(-PLUS) supports #202

Closed
Neustradamus opened this issue Jan 5, 2024 · 6 comments

Comments

@Neustradamus
Copy link

Dear @nodemailer team,

Can you add supports of :

  • SCRAM-SHA-1
  • SCRAM-SHA-1-PLUS
  • SCRAM-SHA-256
  • SCRAM-SHA-256-PLUS
  • SCRAM-SHA-512
  • SCRAM-SHA-512-PLUS
  • SCRAM-SHA3-512
  • SCRAM-SHA3-512-PLUS

You can add too:

  • SCRAM-SHA-224
  • SCRAM-SHA-224-PLUS
  • SCRAM-SHA-384
  • SCRAM-SHA-384-PLUS

"When using the SASL SCRAM mechanism, the SCRAM-SHA-256-PLUS variant SHOULD be preferred over the SCRAM-SHA-256 variant, and SHA-256 variants [RFC7677] SHOULD be preferred over SHA-1 variants [RFC5802]".

https://xmpp.org/extensions/inbox/hash-recommendations.html

-PLUS variants:

IMAP:

LDAP:

  • RFC5803: Lightweight Directory Access Protocol (LDAP) Schema for Storing Salted: Challenge Response Authentication Mechanism (SCRAM) Secrets: https://tools.ietf.org/html/rfc5803

HTTP:

2FA:

IANA:

Linked to:

@andris9
Copy link
Member

andris9 commented Jan 5, 2024

Thank you. I have no plans to add SCRAM methods to the SMTP-server module. Honestly, I don't see any value in SCRAM in the context of TLS and as such, I do not have any time to spend on it. However, I am willing to accept pull requests if you would implement this functionality for the SMTP-server module yourself.

@Neustradamus
Copy link
Author

@andris9: It is not only for SMTP, there are IMAP, POP3 too.
It is in RFC and it is the best security solution.

You can see here a list of products:

You are in the NOTHING list.

Do not forget to remove all old and unsecure mechanisms for security of users...

@andris9
Copy link
Member

andris9 commented Jan 5, 2024

I'll gladly accept any pull requests that would add these mechanisms for SMTP, POP3 and IMAP.

@Neustradamus
Copy link
Author

Badly, I will not do it, I have informed the @nodemailer team.
But for people: ticket closed = it is solved.
Currently nodemailer & co are not secure.
Time to reopen it.

@andris9
Copy link
Member

andris9 commented Jan 5, 2024

The entire Nodemailer team is just me. This is why I don't have time to add all these additional features, and I'm expecting PRs from interested parties.

@Neustradamus
Copy link
Author

@andris9: I see, I invite you to look to improve and secure the project...

Please to do not close an unsolved ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants