Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky test at test/interceptors/dns.js #3898

Closed
ruyadorno opened this issue Nov 28, 2024 · 1 comment · Fixed by #3902
Closed

Flaky test at test/interceptors/dns.js #3898

ruyadorno opened this issue Nov 28, 2024 · 1 comment · Fixed by #3902
Labels
bug Something isn't working

Comments

@ruyadorno
Copy link
Member

When running CITGM to prepare the latest node22 release I stumbled upon the following error:

 test at test/interceptors/dns.js:817:1
  Should set lowest TTL between resolved and option maxTTL (604.890833ms)
   AssertionError [ERR_ASSERTION]: 4 == 3
       at res.<computed> [as equal] (/Users/iojs/tmp/citgm_tmp/d4b30272-eb56-4773-af41-d5c7d9f125bf/undici/node_modules/@matteo.collina/tspl/tspl.js:52:35)
       at TestContext.<anonymous> (/Users/iojs/tmp/citgm_tmp/d4b30272-eb56-4773-af41-d5c7d9f125bf/undici/test/interceptors/dns.js:905:5)
       at process.processTicksAndRejections (node:internal/process/task_queues:105:5)
       at async Test.run (node:internal/test_runner/test:935:9)
       at async Test.processPendingSubtests (node:internal/test_runner/test:633:7) {
     generatedMessage: true,
     code: 'ERR_ASSERTION',
     actual: 4,
     expected: 3,
     operator: '=='
   }

ref: https://ci.nodejs.org/job/citgm-smoker/3516/nodes=osx11/testReport/junit/(root)/citgm/undici_v7_0_0/

cc @metcoder95

@ruyadorno ruyadorno added the bug Something isn't working label Nov 28, 2024
@ruyadorno
Copy link
Member Author

Upon inspecting the test code I noticed that this specific test is using a timer, which in my experience is a recipe for flaky tests, so after pinging the Undici Slack channel and getting a confirmation from @metcoder95, I'm reporting it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant