Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node v21.6 breaks unit tests #2615

Closed
Uzlopak opened this issue Jan 16, 2024 · 3 comments
Closed

node v21.6 breaks unit tests #2615

Uzlopak opened this issue Jan 16, 2024 · 3 comments
Labels
bug Something isn't working Tests Changes related to the unit tests

Comments

@Uzlopak
Copy link
Contributor

Uzlopak commented Jan 16, 2024

While working on eventsource, the unit tests broke in the ci

test at test/fetch/response.js:202:11
✖ Readable with ArrayBuffer chunk still throws (2.742972ms)
  'Promise resolution is still pending but the event loop has already resolved'

test at test/fetch/response.js:168:1
✖ constructing a Response with a ReadableStream body (12.147774ms)
  'Promise resolution is still pending but the event loop has already resolved'

test at test/fetch/response.js:222:1
✖ constructing Response with third party Blob body
  'Promise resolution is still pending but the event loop has already resolved'

test at test/fetch/response.js:227:1
✖ constructing Response with third party FormData body
  'Promise resolution is still pending but the event loop has already resolved'

test at test/fetch/response.js:237:1
✖ Issue#2465
  'Promise resolution is still pending but the event loop has already resolved'

test at test/fetch/response.js:243:1
✖ Check the Content-Type of invalid formData
  'Promise resolution is still pending but the event loop has already resolved'
@Uzlopak Uzlopak added the bug Something isn't working label Jan 16, 2024
@metcoder95 metcoder95 added the Tests Changes related to the unit tests label Jan 16, 2024
@metcoder95
Copy link
Member

Haven't gone through the PR in deep yet, is this still happening or this was due to a change introduced in the PR itself?

@mcollina
Copy link
Member

mcollina commented Jan 16, 2024

The regression was introduced in Node v21.6.0, we need to investigate what exactly

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Jan 27, 2024

Closing as 21.6.1 fixed this issue

@Uzlopak Uzlopak closed this as completed Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Tests Changes related to the unit tests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants