-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a rule to the Node ESLint plugin to flag packages that are now built in to Node.js #110
Comments
That would be a harmful rule imo, unless the package explicitly declares an |
The ESLint rule could maybe define that? This is a just a placeholder issue that I created during our meeting today. It's certainly not a fully thought out proposal. We did discuss that something like this could have some negative affects as well and we'll be discussing it more in future meetings. |
Absolutely it could :-) i just want to caution against anything that could encourage package maintainers to unnecessarily drop support for a platform version, thus cutting off users. |
Yeah, that's definitely a good perspective. We'll be discussing this more and getting more input from the community before moving ahead with anything. |
We've decided (in today's meeting) to close this and open a more generic issue around alerting end users to new features in core when they are using a package/shim/whatever. |
We've started incorporating some third-party packages like
mkdirp
andrimraf
into Node core. We could add a rule to the Node ESLint plugin that would flag this to users if they're using the package in their code. In some cases the npm packages provide additional functionality, for examplerimraf
also provides binlinks so we probably only want to flag certain usages.The text was updated successfully, but these errors were encountered: