Skip to content
This repository has been archived by the owner on May 13, 2019. It is now read-only.

Test/processes that create files that aren't in temp directories #26

Closed
Trott opened this issue Mar 18, 2016 · 5 comments
Closed

Test/processes that create files that aren't in temp directories #26

Trott opened this issue Mar 18, 2016 · 5 comments

Comments

@Trott
Copy link
Member

Trott commented Mar 18, 2016

Find and eliminate tests/processes that create files that aren’t in temp directories or other expected places. (Example: make test-addons creates files in test/addons.)

/cc @thealphanerd

@MylesBorins MylesBorins changed the title Test/processes that creat files that aren't in temp directories Test/processes that create files that aren't in temp directories Mar 18, 2016
@MylesBorins
Copy link
Contributor

I'm into helping on this one.

@Trott
Copy link
Member Author

Trott commented Dec 21, 2017

Checked this in a rough way by running make test in one terminal window on macOS while running sudo fs_usage -w | grep node | egrep '\bopen\b' | grep W | grep -v /dev/ in another terminal window and then lots of manual review of the results. Number of problematic files found is fewer than I expected. PRs coming soon.

@Trott
Copy link
Member Author

Trott commented Dec 21, 2017

nodejs/node#17808

@Trott
Copy link
Member Author

Trott commented Dec 21, 2017

nodejs/node#17810

@Trott
Copy link
Member Author

Trott commented Dec 21, 2017

nodejs/node#17811

And that's the last of them, as far as I can tell. Closing.

@Trott Trott closed this as completed Dec 21, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants