-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for multilines #15
Comments
May be we need to buffer the statements and check if the error is recoverable? Like we do at our node currently : https://github.com/nodejs/node/blob/master/lib/repl.js#L1510 |
we should probably use acorn or something to determine if the input is invalid or unfinished ( |
Yes I thought about |
Hello,
Looks like the current repl doesn't support multiline expression. I was looking at the source code, guess we are passing the expression to
Runtime.evaluate
over here : https://github.com/nodejs/repl/blob/master/src/repl.js#L68Not sure, whether the session's
Runtime.evaluate
supports multilines. But looking at the protocol from here: https://chromium.googlesource.com/v8/v8/+/master/src/inspector/js_protocol.json, I doubt it has the support.The text was updated successfully, but these errors were encountered: