You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Also why do we use SafeStringPrototypeSearch in encode? Cant we just use RegexPrototypeExec? Cant we manually inline the encode function into toString?
Is there a faster way to iterate the SafeMap? Why do we use a SafeMap and not a NullObject (because of the generator functions?
Can we avoid the generator fns? Does it make sense to avoid the generator fns?
Can we optimize parseTypeAndSubtype? Maybe also lazily parse the values? We need to throw errors in special cases, but other than that, we just have to store the string.
Why do we call in MIMEType toString FunctionPrototypeCall(MIMEParamsStringify, this.#parameters); and not this.#parameters.toString()?
Questions over questions...
The text was updated successfully, but these errors were encountered:
I think that MIMEType can be improved significantly.
I created rn a PR regarding lazily parsing the MimeParams.
nodejs/node#49889
Also i could improve toASCIILower with this snippet:
Also why do we use SafeStringPrototypeSearch in encode? Cant we just use RegexPrototypeExec? Cant we manually inline the encode function into toString?
Is there a faster way to iterate the SafeMap? Why do we use a SafeMap and not a NullObject (because of the generator functions?
Can we avoid the generator fns? Does it make sense to avoid the generator fns?
Can we optimize parseTypeAndSubtype? Maybe also lazily parse the values? We need to throw errors in special cases, but other than that, we just have to store the string.
Why do we call in MIMEType toString
FunctionPrototypeCall(MIMEParamsStringify, this.#parameters);
and notthis.#parameters.toString()
?Questions over questions...
The text was updated successfully, but these errors were encountered: