Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hotfix: only one og #7291

Merged
merged 1 commit into from
Nov 29, 2024
Merged

hotfix: only one og #7291

merged 1 commit into from
Nov 29, 2024

Conversation

ovflowd
Copy link
Member

@ovflowd ovflowd commented Nov 28, 2024

Closes #7290

@ovflowd ovflowd requested a review from a team as a code owner November 28, 2024 22:52
@vercel Vercel
Copy link

vercel bot commented Nov 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Nov 28, 2024 10:53pm

@ovflowd ovflowd added fast-track Fast Tracking PRs github_actions:pull-request Trigger Pull Request Checks labels Nov 28, 2024
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Nov 28, 2024
ovflowd
ovflowd commented Nov 28, 2024
View reviewed changes
Copy link
Member Author

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting fast-track @nodejs/nodejs-website

@github-actions GitHub Actions
Copy link
Contributor

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 92%
 90.79% (631/695) 72.44% (184/254) 94.53% (121/128)

Unit Test Report

Tests Skipped Failures Errors Time
143 0 💤 0 ❌ 0 🔥 5.206s ⏱️

benhalverson
benhalverson approved these changes Nov 29, 2024
View reviewed changes
Copy link
Member

@benhalverson benhalverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dog LGTM

@ovflowd ovflowd merged commit 116848f into main Nov 29, 2024
23 checks passed
@ovflowd ovflowd deleted the fix/multiple-og branch November 29, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AugustinMauroy AugustinMauroy AugustinMauroy approved these changes

@benhalverson benhalverson benhalverson approved these changes

Assignees
No one assigned
Labels
fast-track Fast Tracking PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: two OG images per page
3 participants
@ovflowd @benhalverson @AugustinMauroy