chore: use toUpperCase in detectOS
#7241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: CodingRule <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Also I can change it at utils/getNodeDownloadUrl.ts too |
RedYetiDev
reviewed
Nov 19, 2024
Signed-off-by: CodingRule <[email protected]>
Signed-off-by: CodingRule <[email protected]>
|
@RedYetiDev Done Thanks for pointing out to me that I can directly do it with uppercase and I have updated it in your sayings. Thanks! Hope this contribution will help. |
RedYetiDev
reviewed
Nov 19, 2024
RedYetiDev
changed the title
toUpperCase in detectOStoUpperCase in detectOS
RedYetiDev
approved these changes
Nov 19, 2024
Co-authored-by: Aviv Keller <[email protected]> Signed-off-by: CodingRule <[email protected]>
|
Haha thanks! I saw that one coming tbh (= |
thanks good sir! |
|
also quick question @RedYetiDev would I be able to apply the same logic here too? utils/getNodeDownloadUrl.ts too |
|
In a seperate PR, preferably |
github-actions
bot
removed
the
github_actions:pull-request
|
yes ofc |
|
Lighthouse Results
|
Unit Test Coverage Report
Unit Test Report
|
aymen94
approved these changes
Nov 19, 2024
|
Thanks for your contribution, @CodingRule! It's be merged shortly. |
|
Ty! |
bmuenzenmeyer
pushed a commit
that referenced
this pull request
Nov 21, 2024
* Update detectOS.ts Signed-off-by: CodingRule <[email protected]> * Update detectOS.ts Signed-off-by: CodingRule <[email protected]> * Update detectOS.ts Signed-off-by: CodingRule <[email protected]> * Update apps/site/util/detectOS.ts Co-authored-by: Aviv Keller <[email protected]> Signed-off-by: CodingRule <[email protected]> --------- Signed-off-by: CodingRule <[email protected]> Co-authored-by: Aviv Keller <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using the switch statement, we use a faster way with an object. Hope it's not useless tho.