Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: codeowner #6898

Merged
merged 2 commits into from
Jul 8, 2024
Merged

fix: codeowner #6898

merged 2 commits into from
Jul 8, 2024

Conversation

AugustinMauroy
Copy link
Member

Description

During migration to monorepo codeowner wasn't updated.

Validation

it's should represent the correct owning.
It's should be correct code owner

Related Issues

No Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@AugustinMauroy AugustinMauroy requested a review from a team as a code owner July 4, 2024 11:03
Copy link

vercel bot commented Jul 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jul 7, 2024 11:07am

Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to add ./ 👀

But otherwise LGTM

@AugustinMauroy
Copy link
Member Author

AugustinMauroy commented Jul 4, 2024

@ovflowd just app/site/* ?

@mikeesto
Copy link
Member

mikeesto commented Jul 7, 2024

@AugustinMauroy is on leave 🏖️ . In the interests of merging this soon I've updated the branch

@bmuenzenmeyer bmuenzenmeyer merged commit 50bb2de into main Jul 8, 2024
5 checks passed
@bmuenzenmeyer bmuenzenmeyer deleted the fix-codeowner branch July 8, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants