Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revise Debugging Getting Started doc #1969

Merged
merged 5 commits into from
Jan 30, 2019
Merged

revise Debugging Getting Started doc #1969

merged 5 commits into from
Jan 30, 2019
+85 −190

Conversation

Trott
Copy link
Member

@Trott Trott commented Dec 30, 2018

Refs: #1968

/cc @Floriferous

@ghost ghost requested a review from vsemozhetbyt December 31, 2018 13:28
@fhemberger
Copy link
Contributor

Also appears in

fa/docs/guides/getting-started-guide.md
ja/docs/guides/getting-started-guide.md
ko/docs/guides/getting-started-guide.md
zh-cn/docs/guides/getting-started-guide.md

zh-CN: Trans for 'Enable Inspector'
85e87a4 
zh-CN: Trans for 'Enable Inspector'
@ghost
Copy link

ghost commented Jan 1, 2019 •
edited by ghost
Loading

@nodejs/localization：Plz check your own localizations and do translations at Trott:debugging-start

@ghost ghost requested a review from ZYSzys January 1, 2019 10:12
ZYSzys
ZYSzys approved these changes Jan 1, 2019
View reviewed changes
Copy link
Member

@ZYSzys ZYSzys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some nits.

locale/zh-cn/docs/guides/debugging-getting-started.md Outdated Show resolved Hide resolved
locale/zh-cn/docs/guides/debugging-getting-started.md Outdated Show resolved Hide resolved
Fix some Chinese translations
f1455b2 
Fix some Chinese translations
@fhemberger
Copy link
Contributor

@nodejs/nodejs-ko Could you please update the Korean translation?

@yous
Copy link
Contributor

yous commented Jan 2, 2019

@outsideris @taggon Please take a look.

@taggon
Copy link
Contributor

taggon commented Jan 2, 2019

@nodejs/nodejs-ko I will take a look at this tomorrow.

outsideris
outsideris suggested changes Jan 4, 2019
View reviewed changes
Copy link
Contributor

@outsideris outsideris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check this @nodejs/nodejs-ko

locale/ko/docs/guides/debugging-getting-started.md Show resolved Hide resolved
@Trott
Copy link
Member Author

Trott commented Jan 10, 2019

@outsideris @yous You should be able to push commits directly to my branch if you wish. Feel free to do so if you feel confident about the changes. I'd very much like to get this landed.

@yous
Copy link
Contributor

yous commented Jan 14, 2019

Just pushed updates for Korean that applies reviews.

@yous
Copy link
Contributor

yous commented Jan 15, 2019

@nodejs/nodejs-ko Please check this.

@Trott
Copy link
Member Author

Trott commented Jan 29, 2019

Seems like all requests for changes have been addressed? @outsideris

outsideris
outsideris approved these changes Jan 30, 2019
View reviewed changes
Copy link
Contributor

@outsideris outsideris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fhemberger fhemberger merged commit 127626c into nodejs:master Jan 30, 2019
@fhemberger
Copy link
Contributor

Thanks everybody!

@ghost ghost mentioned this pull request Apr 13, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yous yous yous left review comments

@ZYSzys ZYSzys ZYSzys approved these changes

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@willin willin willin approved these changes

@lpinca lpinca lpinca approved these changes

@outsideris outsideris outsideris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@Trott @fhemberger @yous @taggon @outsideris @lpinca @willin @vsemozhetbyt @ZYSzys