-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nodejs-zh-TW: Improve translation #1727
Conversation
- Remove unnecessary quotation mark - Remove unnecessary translation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about removing the quotation marks. Didn't check: Is this valid YAML having two colons? Does the site build?
+1 for removing last sentence!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "Merge" commits should be removed.
It passed tests and looks no difference since I use fullwidth colon. But I will add quotation mark back to avoid confusion. @PeterDaveHello oops, I'll open another PR soon. |
@osk2 :BTW,In fact you can remove Merge with the help of "Reset and Rebase" and re-submit instead of closing that :) |
We'll squash and merge the commits anyway, so no worries about that. |
@Maledong Thanks for the tip, I'll try next time 👍 |
I made some improvements as mentioned in #1719