Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Remove duplicated Translations for index.md with unnecessary double quotes #1719

Merged
1 commit merged into from Jul 12, 2018
Merged

[Fix] Remove duplicated Translations for index.md with unnecessary double quotes #1719

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions locale/zh-cn/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,7 @@ labels:
version-schedule-prompt-link-text: LTS 日程。
newsletter: true
newsletter-prefix: 订阅
newsletter-postfix: "，Node.js 官方的新闻周报。"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change seems to be unrelated.

Copy link
Author

@ghost ghost Jul 10, 2018 •
edited by ghost
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I just mean that removing the last pharagraph, with the image pasted above for you to see. And there doesn't seem to need quotation marks, so I removed in this fix together.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then maybe the PR title should be revised to cover that?

Copy link
Author

@ghost ghost Jul 10, 2018 •
edited by ghost
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. I'll update it. Thanks!

newsletter-postfix: ，Node.js 官方的新闻周报。
---

Node.js® 是一个基于 [Chrome V8 引擎](https://developers.google.com/v8/)的 JavaScript 运行时。
Node.js 使用高效、轻量级的事件驱动、非阻塞 I/O 模型。它的包生态系统，[npm](https://www.npmjs.com/)，是目前世界上最大的开源库生态系统。
Node.js® 是一个基于 [Chrome V8 引擎 ](https://developers.google.com/v8/)的 JavaScript 运行时。