Big green download button on nodejs.org from Linux/x64 gives source archive

[sxa]

URL:

https://nodejs.org

Browser Name:

Firefox

Browser Version:

101.0

Operating System:

Fedora Silverblue 37

How to reproduce the issue:

Go to nodejs.org and try to click the download button for 18 or 20. The URLs point to the source archive e.g. https://nodejs.org/dist/v18.17.0/node-v18.17.0.tar.gz at present, instead of the node-v18.17.0-linux-x64.tar.xz build that I would expect. From the screnshot you can see that it has correctly detected what platform I'm using.

[ovflowd]

I can confirm this is a regression, the current https://github.com/nodejs/nodejs.org/blob/main/util/downloadUrlByOS.ts provides .tar.gz instead of .tar.xz

@sxa feel free to update this file. This should fix your issue afaik. (Opening a PR also deploys a preview where you can check this indeed fixes the issue)

[sxa]

I'll give it a try - thanks for the pointer to where it might be. Since we generally have both tar.gz and tar.xz in the download site I'd have though the current code would have still been able to point ot the gz version.

[ovflowd]

I'll give it a try - thanks for the pointer to where it might be. Since we generally have both tar.gz and tar.xz in the download site I'd have though the current code would have still been able to point ot the gz version.

Yup on the "All Downloads" page you can still download the .gz even if you do this change. This file is pretty much used for the automatic OS detection on the Home page.

[sxa]

It looks like there isn't an easy way to have the architecture detection in that piece of code, so it may require more work to do anything other than hard code for x64 as a 'quick fix'.

It looks like the label on the web page puts 'Linux (x64)' for all Linux variants based on

nodejs.org/layouts/IndexLayout.tsx

Line 17 in 562ed48

return ` Linux (x64)`;

I'll initially hard code it to linux/x64 and see if that works before we look at whether we can enhance it - even if that's in place as a first phase it'l lbe better than what we have at present ';-)

[ovflowd]

I'll initially hard code it to linux/x64 and see if that works before we look at whether we can enhance it - even if that's in place as a first phase it'l lbe better than what we have at present ';-)

That's fine for now. The whole Website and its components and content will be changing soon, so this part will be overhauled very soon. The hot-fix for now at least solves the Linux x64 issue.