test: add coverage for spawnSync() killSignal #8960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mscdex
added
the
child_process
bnoordhuis
approved these changes
Oct 7, 2016
| if (process.argv[2] === 'child') { | ||
| setInterval(() => {}, 1000); | ||
| } else { | ||
| const SIGUSR2 = process.binding('constants').os.signals.SIGUSR2; |
There was a problem hiding this comment.
You could DRY this as const { SIGUSR2 } = process.binding('constants').os.signals. Minor thing though.
|
CI with the suggestion incorporated: https://ci.nodejs.org/job/node-test-pull-request/4445/ |
|
Related failures on Windows. |
cjihrig
force-pushed
the
killsignal
branch
2 times, most recently
from
dc1c87f
to
532e7f7
Compare
|
It looks like CI: https://ci.nodejs.org/job/node-test-pull-request/4447/. The only failures are now unrelated. |
This commit adds a test for the killSignal option to spawnSync(), and the other sync child process functions by extension. PR-URL: nodejs#8960 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
jasnell
pushed a commit
that referenced
this pull request
Oct 10, 2016
This commit adds a test for the killSignal option to spawnSync(), and the other sync child process functions by extension. PR-URL: #8960 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
Fishrock123
pushed a commit
that referenced
this pull request
Oct 11, 2016
This commit adds a test for the killSignal option to spawnSync(), and the other sync child process functions by extension. PR-URL: #8960 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 22, 2016
This commit adds a test for the killSignal option to spawnSync(), and the other sync child process functions by extension. PR-URL: #8960 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change
This commit adds a test for the
killSignaloption tospawnSync(), and the other sync child process functions by extension.This was previously untested according to https://node-core-coverage.addaleax.net/