test: update weak module for gc tests

[Trott]

Checklist

• tests and code linting passes
• the commit message follows commit guidelines

Affected core subsystem(s)

test

Description of change

Previous version of weak used for gc tests emitted a warning on OS X.
Updating to current version eliminates warning.

R=@bnoordhuis?

[bnoordhuis]

I'm not about to review a +9,391 −279 diff so rubber-stamp LGTM.

Meta: The gc tests are not run regularly. How about we either add them to the CI or we scrap them? I personally don't find them that valuable but I'm interested in what others think.

[jasnell]

Oy, yeah, that diff is harsh lol. rubber-stamp LGTM here also if CI is possible. Also agree with @bnoordhuis in that if we're not running these regularly, they're not of very much use to keep around.

[Fishrock123]

Maybe we should run these in citgm? cc @thealphanerd ?

[Trott]

@Fishrock123 The changes are in test/gc/node_modules. I may be mistaken, but I don't think CITGM would be affected by that or exercise that code at all. In fact, I'm pretty sure nothing is affected except people (like me) who sometimes run make test-gc at the command line.

[Trott]

@Fishrock123 Oh, wait, maybe you're just suggesting that weak be added to the list of modules that CITGM tests? If so: Yes, +1 to that.

[Fishrock123]

@Trott I'm suggesting that maybe we should put it in a separate repo and include it in the citgm tests.

[Trott]

CI: https://ci.nodejs.org/job/node-test-pull-request/2883/

EDIT: One Pi buildbot explosion and one Pi inexplicably hung during a git operation. Otherwise, all green in CI.

[Trott]

Landed in 0d7f313