test: fix flaky test-http-client-abort #6124
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trott
added
http
|
Stress test showing this version of the test is not flaky on pi2-raspbian-wheezy: https://ci.nodejs.org/job/node-stress-single-test/586/nodes=pi2-raspbian-wheezy/console |
|
LGTM |
1 similar comment
|
LGTM |
|
Stress test showing the version of this test that is on master is flaky: |
|
Only 999 runs? ;-) LGTM though |
|
LGTM |
jasnell
pushed a commit
that referenced
this pull request
Apr 9, 2016
Fixes: #6080 PR-URL: #6124 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Brian White <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Landed in a9aa199 |
MylesBorins
pushed a commit
that referenced
this pull request
Apr 19, 2016
Fixes: #6080 PR-URL: #6124 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Brian White <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Apr 20, 2016
Fixes: #6080 PR-URL: #6124 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Brian White <[email protected]> Reviewed-By: James M Snell <[email protected]>
Closed
MylesBorins
pushed a commit
that referenced
this pull request
Apr 20, 2016
Fixes: #6080 PR-URL: #6124 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Brian White <[email protected]> Reviewed-By: James M Snell <[email protected]>
jasnell
pushed a commit
that referenced
this pull request
Apr 26, 2016
Fixes: #6080 PR-URL: #6124 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Brian White <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
May 17, 2016
Fixes: #6080 PR-URL: #6124 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Brian White <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
May 18, 2016
Fixes: #6080 PR-URL: #6124 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Brian White <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
test http arm
Description of change
Fixes: #6080