process: fix process.features.typescript when Amaro is unavailable

[aduh95]

Fixes: #55320 (comment)

[nodejs-github-bot]

Review requested:

• @nodejs/startup

[richardlau]

$ ./node -p process.config.variables.node_use_amaro
false
$ ./node -p process.features.typescript
false
$

🎉

FWIW, with (and without) this PR I get this:

$ ./node --experimental-transform-types -p process.features.typescript
node:internal/bootstrap/realm:429
  if (!mod) throw new TypeError(`Missing internal module '${id}'`);
            ^

TypeError: Missing internal module 'internal/deps/amaro/dist/index'
    at requireBuiltin (node:internal/bootstrap/realm:429:19)
    at loadTypeScriptParser (node:internal/modules/helpers:346:19)
    at stripTypeScriptTypes (node:internal/modules/helpers:368:17)
    at node:internal/main/eval_string:27:3

Node.js v23.0.0-pre
$

If I try to use --experimental-transform-types (or --experimental-strip-types), which is coming from

node/lib/internal/modules/helpers.js

Line 346 in accb239

const amaro = require('internal/deps/amaro/dist/index');

.

Just running with the experimental options but dropping into the REPL doesn't throw:

$ ./node --experimental-transform-types
Welcome to Node.js v23.0.0-pre.
Type ".help" for more information.
> (node:95351) ExperimentalWarning: Type Stripping is an experimental feature and might change at any time
(Use `node --trace-warnings ...` to show where the warning was created)

>

[aduh95]

FWIW, with (and without) this PR I get this:

I think that's because it assumes the string you pass is TS. Can you try the following instead:

echo 'console.log(process.features.typescript)' > file.cjs
./node --experimental-transform-types file.cjs

[richardlau]

FWIW, with (and without) this PR I get this:

I think that's because it assumes the string you pass is TS. Can you try the following instead:

echo 'console.log(process.features.typescript)' > file.cjs
./node --experimental-transform-types file.cjs

👍

$ echo 'console.log(process.features.typescript)' > file.cjs
$ ./node --experimental-transform-types file.cjs
false
(node:96078) ExperimentalWarning: Type Stripping is an experimental feature and might change at any time
(Use `node --trace-warnings ...` to show where the warning was created)

I think we probably still want some kind of guard, or maybe make the experimental options conditional on Amaro being used, but that could be done in (yet another) follow on PR.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.41%. Comparing base (a05cb0d) to head (60dce1f).
Report is 269 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/internal/bootstrap/node.js	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #55323      +/-   ##
==========================================
- Coverage   88.41%   88.41%   -0.01%     
==========================================
  Files         652      652              
  Lines      186762   186740      -22     
  Branches    36099    36036      -63     
==========================================
- Hits       165123   165099      -24     
- Misses      14902    14908       +6     
+ Partials     6737     6733       -4     

Files with missing lines	Coverage Δ
lib/internal/bootstrap/node.js	99.56% <0.00%> (-0.22%)	⬇️

... and 58 files with indirect coverage changes

[marco-ippolito]

I added the guard in this open PR #55282
Like crypto and icu throw an error ERR_NO_TYPESCRIPT when amaro is not available
Maybe I can split it in a different PR

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/63021/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/63037/

[nodejs-github-bot]

Commit Queue failed

- Loading data for nodejs/node/pull/55323
✔  Done loading data for nodejs/node/pull/55323
----------------------------------- PR info ------------------------------------
Title      process: fix `process.features.typescript` when Amaro is unavailable (#55323)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     aduh95:process.features.typescript--without-amaro -> nodejs:main
Labels     process, author ready, needs-ci, strip-types
Commits    3
 - process: fix `process.features.typescript` when Amaro is unavailable
 - fixup! process: fix `process.features.typescript` when Amaro is unava…
 - fixup! process: fix `process.features.typescript` when Amaro is unava…
Committers 1
 - Antoine du Hamel <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/55323
Reviewed-By: Marco Ippolito <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/55323
Reviewed-By: Marco Ippolito <[email protected]>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 08 Oct 2024 16:49:34 GMT
   ✔  Approvals: 1
   ✔  - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/55323#pullrequestreview-2359200332
   ✘  This PR needs to wait 105 more hours to land (or 0 hours if there is one more approval)
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2024-10-10T20:46:07Z: https://ci.nodejs.org/job/node-test-pull-request/63037/
- Querying data for job/node-test-pull-request/63037/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/11287733011

[nodejs-github-bot]

Landed in f98d9c1