tls: fix assert in context._external accessor #5521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnoordhuis
added
tls
|
Tests pass locally. CI is timing out and I have to step out for a bit, will revisit when I get back. |
|
LGTM |
* Restrict the receiver to instances of the FunctionTemplate. * Use `args.This()` instead of `args.Holder()`. Fixes: nodejs#3682 PR-URL: nodejs#5521 Reviewed-By: Fedor Indutny <[email protected]>
Fishrock123
pushed a commit
that referenced
this pull request
Mar 2, 2016
* Restrict the receiver to instances of the FunctionTemplate. * Use `args.This()` instead of `args.Holder()`. Fixes: #3682 PR-URL: #5521 Reviewed-By: Fedor Indutny <[email protected]>
|
adding the lts-watch flag @bnoordhuis it is safe to assume you think this should be backported |
|
one more time pinging @bnoordhuis. Maybe @indutny knows. This landed cleanly and tests passed locally |
|
If it builds - it is safe to land it. |
MylesBorins
pushed a commit
that referenced
this pull request
Mar 17, 2016
* Restrict the receiver to instances of the FunctionTemplate. * Use `args.This()` instead of `args.Holder()`. Fixes: #3682 PR-URL: #5521 Reviewed-By: Fedor Indutny <[email protected]>
|
@thealphanerd For posterity, yes, it should be back-ported. |
MylesBorins
pushed a commit
that referenced
this pull request
Mar 21, 2016
* Restrict the receiver to instances of the FunctionTemplate. * Use `args.This()` instead of `args.Holder()`. Fixes: #3682 PR-URL: #5521 Reviewed-By: Fedor Indutny <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 21, 2016
* Restrict the receiver to instances of the FunctionTemplate. * Use `args.This()` instead of `args.Holder()`. Fixes: #3682 PR-URL: #5521 Reviewed-By: Fedor Indutny <[email protected]>
|
We have an internal consumer that ran into what looked like nodejs/node-v0.x-archive#9028 and our tests have indicated that that the this PR has resolved the issue. Long way of saying +1 to getting this landed in the next 4.X releases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
args.This()instead ofargs.Holder().Fixes: #3682
R=@indutny