Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_runner: improve code coverage cleanup #54856

Merged
merged 1 commit into from
Sep 11, 2024

Commits on Sep 9, 2024

  1. test_runner: improve code coverage cleanup

    The test runner's code coverage leaves old coverage data in the
    temp directory. This commit updates the cleanup logic to:
    
    - Stop code collection. Otherwise V8 would write collection data
      again when the process exits.
    - Remove the temp directory containing the coverage data.
    - Attempt to clean up the coverage data even if parsing the
      data resulted in an error.
    
    With this change, I no longer see any coverage data left behind
    in the system temp directory.
    
    Refs: nodejs/build#3864
    Refs: nodejs/build#3887
    cjihrig committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    4b39649 View commit details
    Browse the repository at this point in the history