doc: clarify error handling in net/createServer #5353
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. /cc @trevnorris |
mscdex
added
doc
|
It would be good if the commit log message identified what was clarified a bit more specifically. |
|
@jasnell good point. Can you please check the new commit message? |
| server.listen(8124, (err) => { | ||
| // 'listening' listener | ||
| if (err) throw err; | ||
| server.listen(8124, () => { |
There was a problem hiding this comment.
I would add an error listener here as well.
Remove indications that an error argument is sent to the `listen()` callback. Fixes: nodejs#5345 PR-URL: nodejs#5353
|
LGTM. Thanks for looking into this. |
|
LGTM. |
evanlucas
pushed a commit
that referenced
this pull request
Feb 25, 2016
Remove indications that an error argument is sent to the `listen()` callback. Fixes: #5345 PR-URL: #5353 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trevor Norris <[email protected]>
|
Landed in 581606a. Thanks! |
rvagg
pushed a commit
that referenced
this pull request
Feb 27, 2016
Remove indications that an error argument is sent to the `listen()` callback. Fixes: #5345 PR-URL: #5353 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trevor Norris <[email protected]>
rvagg
pushed a commit
that referenced
this pull request
Feb 27, 2016
Remove indications that an error argument is sent to the `listen()` callback. Fixes: #5345 PR-URL: #5353 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trevor Norris <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 1, 2016
Remove indications that an error argument is sent to the `listen()` callback. Fixes: #5345 PR-URL: #5353 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trevor Norris <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 1, 2016
Remove indications that an error argument is sent to the `listen()` callback. Fixes: #5345 PR-URL: #5353 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trevor Norris <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 2, 2016
Remove indications that an error argument is sent to the `listen()` callback. Fixes: #5345 PR-URL: #5353 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trevor Norris <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #5345