Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools,doc: parse types in braces everywhere #5329

Closed
wants to merge 1 commit into from
Closed

tools,doc: parse types in braces everywhere #5329

wants to merge 1 commit into from

Conversation

estliberitas
Copy link
Contributor

Also add EvalError, RangeError, ReferenceError, SyntaxError,
TypeError, URIError to list of global types. Fix errors.markdown
copy accordingly.

Fixes #5325.

estliberitas
estliberitas reviewed Feb 19, 2016
View reviewed changes
tools/doc/html.js
@@ -114,6 +114,10 @@ function parseLists(input) {
var output = [];
output.links = input.links;
input.forEach(function(tok) {
if (tok.type === 'text' && tok.text) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will have side effects, only if we will write something like....

Some missing {type} or { code: 'without backquote' }

@mscdex mscdex added doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory. labels Feb 19, 2016
jasnell
jasnell reviewed Feb 19, 2016
View reviewed changes
doc/api/errors.markdown
@@ -6,13 +6,13 @@ Applications running in Node.js will generally experience four categories of
errors:

- Standard JavaScript errors such as:
- [`EvalError`][]: thrown when a call to `eval()` fails.
- [`SyntaxError`][]: thrown in response to improper JavaScript language
- {EvalError} : thrown when a call to `eval()` fails.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove these links?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to mention #5325 in a commit. This is why actually I created PR. #5325 in turn was caused by #5322

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @estliberitas , since #5641 fixes the broken links, do we still need to remove them?

@jasnell
Copy link
Member

jasnell commented Feb 20, 2016

+1... ok, LGTM!

@silverwind
Copy link
Contributor

This needs a rebase now.

@estliberitas
Copy link
Contributor Author

@silverwind Done

@estliberitas estliberitas mentioned this pull request Mar 10, 2016
Closed
@jasnell
Copy link
Member

jasnell commented Apr 2, 2016

Oy.. looks like it needs another rebase. If you can get that I'll look at landing next week

@estliberitas
Copy link
Contributor Author

@jasnell I'll fix tmrw

@estliberitas
tools,doc: parse types in braces everywhere
220e2d7 
Also add `EvalError`, `RangeError`, `ReferenceError`, `SyntaxError`,
`TypeError`, `URIError` to list of global types. Fix errors.markdown
copy accordingly.

Fixes #5325.
@estliberitas
Copy link
Contributor Author

@jasnell done

@jasnell
Copy link
Member

jasnell commented Apr 4, 2016

@nodejs/documentation ... another quick review please? :-)

@eljefedelrodeodeljefe
Copy link
Contributor

LGTM

@eljefedelrodeodeljefe
Copy link
Contributor

ping @jasnell

@jasnell
Copy link
Member

jasnell commented Apr 18, 2016

LGTM

jasnell pushed a commit that referenced this pull request Apr 18, 2016
@estliberitas @jasnell
tools,doc: parse types in braces everywhere
eafd31a 
Also add `EvalError`, `RangeError`, `ReferenceError`, `SyntaxError`,
`TypeError`, `URIError` to list of global types. Fix errors.markdown
copy accordingly.

Fixes: #5325.
PR-URL: #5329
Reviewed-By: James M Snell <[email protected]>
@jasnell
Copy link
Member

jasnell commented Apr 18, 2016

Landed in eafd31a

@jasnell jasnell closed this Apr 18, 2016
MylesBorins pushed a commit that referenced this pull request Apr 19, 2016
@estliberitas
tools,doc: parse types in braces everywhere
3a6d776 
Also add `EvalError`, `RangeError`, `ReferenceError`, `SyntaxError`,
`TypeError`, `URIError` to list of global types. Fix errors.markdown
copy accordingly.

Fixes: #5325.
PR-URL: #5329
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 20, 2016
@estliberitas
tools,doc: parse types in braces everywhere
07484a9 
Also add `EvalError`, `RangeError`, `ReferenceError`, `SyntaxError`,
`TypeError`, `URIError` to list of global types. Fix errors.markdown
copy accordingly.

Fixes: #5325.
PR-URL: #5329
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 20, 2016
@estliberitas
tools,doc: parse types in braces everywhere
2567f2d 
Also add `EvalError`, `RangeError`, `ReferenceError`, `SyntaxError`,
`TypeError`, `URIError` to list of global types. Fix errors.markdown
copy accordingly.

Fixes: #5325.
PR-URL: #5329
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Apr 20, 2016
Closed
MylesBorins pushed a commit that referenced this pull request Apr 20, 2016
@estliberitas
tools,doc: parse types in braces everywhere
d516412 
Also add `EvalError`, `RangeError`, `ReferenceError`, `SyntaxError`,
`TypeError`, `URIError` to list of global types. Fix errors.markdown
copy accordingly.

Fixes: #5325.
PR-URL: #5329
Reviewed-By: James M Snell <[email protected]>
This was referenced Apr 21, 2016
Closed
Closed
MylesBorins pushed a commit that referenced this pull request Apr 21, 2016
@estliberitas @MylesBorins
tools,doc: parse types in braces everywhere
0658632 
Also add `EvalError`, `RangeError`, `ReferenceError`, `SyntaxError`,
`TypeError`, `URIError` to list of global types. Fix errors.markdown
copy accordingly.

Fixes: #5325.
PR-URL: #5329
Reviewed-By: James M Snell <[email protected]>
joelostrowski pushed a commit to joelostrowski/node that referenced this pull request Apr 25, 2016
@estliberitas @joelostrowski
tools,doc: parse types in braces everywhere
2620716 
Also add `EvalError`, `RangeError`, `ReferenceError`, `SyntaxError`,
`TypeError`, `URIError` to list of global types. Fix errors.markdown
copy accordingly.

Fixes: nodejs#5325.
PR-URL: nodejs#5329
Reviewed-By: James M Snell <[email protected]>
jasnell pushed a commit that referenced this pull request Apr 26, 2016
@estliberitas @jasnell
tools,doc: parse types in braces everywhere
df9e6fb 
Also add `EvalError`, `RangeError`, `ReferenceError`, `SyntaxError`,
`TypeError`, `URIError` to list of global types. Fix errors.markdown
copy accordingly.

Fixes: #5325.
PR-URL: #5329
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request May 3, 2016
@estliberitas
tools,doc: parse types in braces everywhere
aeea832 
Also add `EvalError`, `RangeError`, `ReferenceError`, `SyntaxError`,
`TypeError`, `URIError` to list of global types. Fix errors.markdown
copy accordingly.

Fixes: #5325.
PR-URL: #5329
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request May 6, 2016
@estliberitas
tools,doc: parse types in braces everywhere
ab7f3dd 
Also add `EvalError`, `RangeError`, `ReferenceError`, `SyntaxError`,
`TypeError`, `URIError` to list of global types. Fix errors.markdown
copy accordingly.

Fixes: #5325.
PR-URL: #5329
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request May 18, 2016
@estliberitas
tools,doc: parse types in braces everywhere
c893cd3 
Also add `EvalError`, `RangeError`, `ReferenceError`, `SyntaxError`,
`TypeError`, `URIError` to list of global types. Fix errors.markdown
copy accordingly.

Fixes: #5325.
PR-URL: #5329
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request May 18, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@estliberitas @jasnell @silverwind @eljefedelrodeodeljefe @stevemao @mscdex @MylesBorins