Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: use v8::(Des|S)erializeInternalFieldsCallback #53217

Merged
merged 1 commit into from
Jun 7, 2024

Commits on May 30, 2024

  1. src: use v8::(Des|S)erializeInternalFieldsCallback

    Previously V8 would just try to serialize the context data fields
    "verbatim" by copying the pointer values. This patch makes
    use of the new callbacks so that at serialization, the embedder
    data for the context can at least be serialized in a meaningful
    way (which are all reset to empty for now). Otherwise the
    upstream may have difficulties serializing these pointer values
    "verbatim" especially with the introduction of external pointer
    tables, even though the verbatim pointer values from a previous
    process is meaningless to Node.js.
    
    For Node.js the callback currently just checks that the slots are
    know. We will reassign the pointers with newly created native
    structures during deserialization and there isn't much we can
    reuse for now.
    joyeecheung committed May 30, 2024
    Configuration menu
    Copy the full SHA
    500ab76 View commit details
    Browse the repository at this point in the history