deps: cherry-pick 2e4da65 from v8's 4.8 upstream #5293
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Float v8 patch, which has been committed to v8 master and backported to 4.8 and 4.9 in google repos, onto 4.8 v8 in deps to resolve nodejs#5089 Original title/commit from google repos for 4.8 is: PPC: [turbofan] Support for CPU models lacking isel. v8/v8@2e4da65
|
Solid work in #5089. LGTM. |
|
Test run against AIX here: https://ci.nodejs.org/job/node-test-commit-aix/51/ |
|
Rubberstamp LGTM. |
|
node-test-pull-request CI run - https://ci.nodejs.org/job/node-test-pull-request/1695/ Looks clean, only one failure on arm which is a network timeout and since this change only affects power not related to this change. |
mhdawson
added a commit
that referenced
this pull request
Feb 18, 2016
Float v8 patch, which has been committed to v8 master and backported to 4.8 and 4.9 in google repos, onto 4.8 v8 in deps to resolve #5089 Original title/commit from google repos for 4.8 is: PPC: [turbofan] Support for CPU models lacking isel. v8/v8@2e4da65 PR-URL: #5293 Fixes: #5089 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: jbergstroem - Johan Bergström <[email protected]>
|
Landed as ff0d339 |
|
Aix test run on master is green: https://ci.nodejs.org/job/node-test-commit-aix/52/ |
mtbrandy
pushed a commit
to ibmruntimes/node
that referenced
this pull request
Feb 18, 2016
Float v8 patch, which has been committed to v8 master and backported to 4.8 and 4.9 in google repos, onto 4.8 v8 in deps to resolve nodejs/node#5089 Original title/commit from google repos for 4.8 is: PPC: [turbofan] Support for CPU models lacking isel. v8/v8@2e4da65 PR-URL: nodejs/node#5293 Fixes: nodejs/node#5089 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: jbergstroem - Johan Bergström <[email protected]>
richardlau
pushed a commit
to ibmruntimes/node
that referenced
this pull request
Feb 18, 2016
Float v8 patch, which has been committed to v8 master and backported to 4.8 and 4.9 in google repos, onto 4.8 v8 in deps to resolve nodejs/node#5089 Original title/commit from google repos for 4.8 is: PPC: [turbofan] Support for CPU models lacking isel. v8/v8@2e4da65 PR-URL: nodejs/node#5293 Fixes: nodejs/node#5089 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: jbergstroem - Johan Bergström <[email protected]>
|
@nodejs/v8 this cleanly cherry-picks on to |
|
From looking at |
|
LGTM to backport. This is fixing a crash bug on specific Power architecture versions. There is no risk to non-Power hardware. |
|
LGTM |
|
Please mention @nodejs/v8 in the future, I haven't seen this PR before. |
|
Belated LGTM |
rvagg
pushed a commit
that referenced
this pull request
Feb 21, 2016
Float v8 patch, which has been committed to v8 master and backported to 4.8 and 4.9 in google repos, onto 4.8 v8 in deps to resolve #5089 Original title/commit from google repos for 4.8 is: PPC: [turbofan] Support for CPU models lacking isel. v8/v8@2e4da65 PR-URL: #5293 Fixes: #5089 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: jbergstroem - Johan Bergström <[email protected]>
|
based on @bnoordhuis's comment I'm adding the lts-watch flag. |
|
SGTM |
MylesBorins
pushed a commit
that referenced
this pull request
Mar 17, 2016
Float v8 patch, which has been committed to v8 master and backported to 4.8 and 4.9 in google repos, onto 4.8 v8 in deps to resolve #5089 Original title/commit from google repos for 4.8 is: PPC: [turbofan] Support for CPU models lacking isel. v8/v8@2e4da65 PR-URL: #5293 Fixes: #5089 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: jbergstroem - Johan Bergström <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 21, 2016
Float v8 patch, which has been committed to v8 master and backported to 4.8 and 4.9 in google repos, onto 4.8 v8 in deps to resolve #5089 Original title/commit from google repos for 4.8 is: PPC: [turbofan] Support for CPU models lacking isel. v8/v8@2e4da65 PR-URL: #5293 Fixes: #5089 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: jbergstroem - Johan Bergström <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Float v8 patch, which has been committed to v8 master and
backported to 4.8 and 4.9 in google repos, onto 4.8 v8 in
deps to resolve #5089
Original title/commit from google repos for 4.8 is:
PPC: [turbofan] Support for CPU models lacking isel.
v8/v8@2e4da65