path: fix input type checking regression #5244
Conversation
|
ci: https://ci.nodejs.org/job/node-test-pull-request/1671/ citgm + CI are green (expected failures on ppc) LGTM |
|
@thealphanerd Yes, it should. |
|
yay for smoke testing! yay for more tests! this is a great outcome of more thorough processes. |
|
oh, and fix lgtm, 🚢 |
|
@mscdex so it looks like this patch is not applying cleanly to v5.x (although it is for master). Would you be able to take a peak? |
|
LGTM |
| @@ -698,7 +698,8 @@ const win32 = { | |||
|
|
|||
|
|
|||
| dirname: function dirname(path) { | |||
| assertPath(path); | |||
| if (typeof path !== 'string') | |||
There was a problem hiding this comment.
We can skip this check and simply do path = '' + path, right?
There was a problem hiding this comment.
It probably doesn't matter either way. I just did it this way in case v8 doesn't/can't optimize it by not creating a new string if path is already a string.
There was a problem hiding this comment.
Just thinking out loud here. Will path = path.toString() be better then?
There was a problem hiding this comment.
That's effectively the same as path = '' + path but less safe (e.g. won't work on null and other values).
There was a problem hiding this comment.
Oh yeah. Totally forgot about them.
|
LGTM |
Before b212be0, input types were not checked in some path functions and the inputs were passed directly to `regexp.exec()` which implicitly converts its argument to a string. This commit both removes the type checking added in b212be0 and adds string coercion for those functions. PR-URL: #5244 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
|
Landed in 9209bf6. |
|
@rvagg Do you want me to submit a separate PR for inclusion into v5.x or will it get cherry-picked at some point (and should be tagged with |
|
@mscdex the cherry-picking process for v5.x is opt-out rather than opt-in like v4.x so this'll come across in my next update (within the next couple of ours), no need to take action on your part except for PRs that shouldn't go in to v5.x. Thanks for fixing! |
Before b212be0, input types were not checked in some path functions and the inputs were passed directly to `regexp.exec()` which implicitly converts its argument to a string. This commit both removes the type checking added in b212be0 and adds string coercion for those functions. PR-URL: #5244 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Before b212be0, input types were not checked in some path functions and the inputs were passed directly to
regexp.exec()which implicitly converts its argument to a string.This commit both removes the type checking added in b212be0 and adds string coercion for those functions.
/cc @thealphanerd