[v18.x] deps: V8: cherry-pick d15d49b09dc7 #52337
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original commit message:
Make bitfields only as wide as necessary for enums
clang now complains when a BitField for an enum is too wide.
We could suppress this, but it seems kind of useful from an
uninformed distance, so I made a few bitfields smaller instead.
(For AddressingMode, since its size is target-dependent, I added
an explicit underlying type to the enum instead, which suppresses
the diag on a per-enum basis.)
This is without any understanding of the code I'm touching.
Especially the change in v8-internal.h feels a bit risky to me.
Bug: chromium:1348574
Change-Id: I73395de593045036b72dadf4e3147b5f7e13c958
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3794708
Commit-Queue: Nico Weber <[email protected]>
Reviewed-by: Leszek Swirski <[email protected]>
Reviewed-by: Hannes Payer <[email protected]>
Auto-Submit: Nico Weber <[email protected]>
Cr-Commit-Position: refs/heads/main@{#82109}
Refs: v8/v8@d15d49b
|
Review requested:
|
nodejs-github-bot
added
build
github-actions
bot
removed
the
request-ci
RafaelGSS
approved these changes
Apr 12, 2024
github-actions
bot
removed
the
request-ci
chenrui333
reviewed
Apr 16, 2024
richardlau
pushed a commit
that referenced
this pull request
Apr 17, 2024
Original commit message:
Make bitfields only as wide as necessary for enums
clang now complains when a BitField for an enum is too wide.
We could suppress this, but it seems kind of useful from an
uninformed distance, so I made a few bitfields smaller instead.
(For AddressingMode, since its size is target-dependent, I added
an explicit underlying type to the enum instead, which suppresses
the diag on a per-enum basis.)
This is without any understanding of the code I'm touching.
Especially the change in v8-internal.h feels a bit risky to me.
Bug: chromium:1348574
Change-Id: I73395de593045036b72dadf4e3147b5f7e13c958
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3794708
Commit-Queue: Nico Weber <[email protected]>
Reviewed-by: Leszek Swirski <[email protected]>
Reviewed-by: Hannes Payer <[email protected]>
Auto-Submit: Nico Weber <[email protected]>
Cr-Commit-Position: refs/heads/main@{#82109}
Refs: v8/v8@d15d49b
PR-URL: #52337
Fixes: #52230
Reviewed-By: Rafael Gonzaga <[email protected]>
|
Landed in 678641f. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original commit message:
Refs: v8/v8@d15d49b
Fixes: #52230
(Note that this change is already in the baseline v8 of v20.x and newer, hence why this is a v18-only cherry-pick)
I carefully combed through this patch. The
NodeStatechanges (include/v8-internal.handsrc/handles/global-handles.cc) are not included, as the enum on v18.x is slightly larger (v18.x vs at time of v8 patch) so the current 3 bits is correct. And just to check:make jstestwas able to catch this correctly.I can confirm this patch fixes the build on Xcode 15.3.
We also have advance notice that this will be a hard error in LLVM Clang 19 (later this year) so
-Wno-enum-constexpr-conversionwould not have been a long-term fix:https://releases.llvm.org/18.1.0/tools/clang/docs/ReleaseNotes.html