-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
console: apply null as this
for util.format
#5222
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the util.format just a stateless function. apply current console as `this` is unnecessary.
JacksonTian
force-pushed
the
apply_null
branch
from
February 14, 2016 07:39
f9239d4
to
0b31fc3
Compare
JacksonTian
changed the title
console: apply null as
console: apply null as Feb 14, 2016
this
for util.format`this
for util.format
LGTM |
LGTM |
targos
pushed a commit
that referenced
this pull request
Feb 18, 2016
Util.format is just a stateless function. Apply current console as `this` is unnecessary. PR-URL: #5222 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Landed in 0903b6d |
rvagg
pushed a commit
that referenced
this pull request
Feb 21, 2016
Util.format is just a stateless function. Apply current console as `this` is unnecessary. PR-URL: #5222 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 1, 2016
Util.format is just a stateless function. Apply current console as `this` is unnecessary. PR-URL: #5222 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 1, 2016
Util.format is just a stateless function. Apply current console as `this` is unnecessary. PR-URL: #5222 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 2, 2016
Util.format is just a stateless function. Apply current console as `this` is unnecessary. PR-URL: #5222 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the util.format just a stateless function. apply current console
as
this
is unnecessary.